Skip to content

fix(web): restore pointer cursors for sidebar actions#894

Open
binbandit wants to merge 2 commits intopingdotgg:mainfrom
binbandit:t3code/fix-thread-project-button-cursors
Open

fix(web): restore pointer cursors for sidebar actions#894
binbandit wants to merge 2 commits intopingdotgg:mainfrom
binbandit:t3code/fix-thread-project-button-cursors

Conversation

@binbandit
Copy link
Contributor

@binbandit binbandit commented Mar 11, 2026 •
edited by macroscopeapp bot
Loading

Summary

  • restore pointer cursors for sidebar menu buttons, submenu buttons, and project header actions
  • remove the thread row cursor override that forced a default cursor on clickable rows
  • add a regression test covering default pointer cursors and the project drag-handle override

Why

Thread rows and project actions such as Show more were clickable but did not consistently present a pointer cursor on hover. The current code on main still had a cursor-default override on thread rows and no shared pointer cursor in the sidebar interactive primitives.

Validation

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test src/components/ui/sidebar.test.tsx

Note

Restore pointer cursors for sidebar menu buttons and thread rows

Adds cursor-pointer to sidebarMenuButtonVariants, SidebarMenuAction, and SidebarMenuSubButton in sidebar.tsx, and fixes resolveThreadRowClassName in Sidebar.logic.ts to use cursor-pointer instead of cursor-default. New tests in sidebar.test.tsx verify the default cursor and that it can be overridden with a custom class.

Macroscope summarized a8140f5.

@coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4b8c3156-3e14-4756-b2fb-425b7f8d6a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.

Add a configuration file to your project to customize how CodeRabbit runs oxc.

@github-actions github-actions bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Mar 11, 2026
@maria-rcks
Copy link
Collaborator

maria-rcks commented Mar 17, 2026

@binbandit could you rebase / fix conflicts?

@github-actions github-actions bot added the size:M 30-99 changed lines (additions + deletions). label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@binbandit @maria-rcks